Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2377553002: Revert of Enable goma on pdfium buildbots by default. (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2367263002/ ) Reason for revert: Sorry, this CL also breaks build warterfall on Windows. https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/1666 Uncaught Exception https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/1666/steps/Uncaught%20Exception/logs/stdio need close before unlink in raw_io? Original issue's description: > Enable goma on pdfium buildbots by default. > > This CL is reland of https://codereview.chromium.org/2297663007/ > fix: set goma_dir in 'gn gen' step. > > BUG=643139 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/df6070deda2483b959814f4af4ed12bc56a708ac TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643139 Committed: https://chromium.googlesource.com/chromium/tools/build/+/3e51f3b4787dcc251a4d751572e1c1fd234e874a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4453 lines) Patch
M scripts/slave/recipes/pdfium.py View 5 chunks +3 lines, -14 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/android.json View 2 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/drm_win_xfa.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_asan.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_no_v8.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_skia.json View 2 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_no_v8.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_skia.json View 2 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_no_v8.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_skia.json View 2 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_32.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json View 3 chunks +3 lines, -193 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_rel.json View 3 chunks +3 lines, -193 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tikuta
Created Revert of Enable goma on pdfium buildbots by default.
4 years, 2 months ago (2016-09-27 02:42:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377553002/1
4 years, 2 months ago (2016-09-27 02:42:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/3e51f3b4787dcc251a4d751572e1c1fd234e874a
4 years, 2 months ago (2016-09-27 02:42:38 UTC) #5
Dirk Pranke
4 years, 2 months ago (2016-09-27 17:57:57 UTC) #6
Message was sent while issue was closed. 
rs- lgtm.

Powered by Google App Engine
This is Rietveld 408576698