Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2377513006: Reland of Preparse inner functions (new try) (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Preparse inner functions (new try) (patchset #1 id:1 of https://codereview.chromium.org/2373443003/ ) Reason for revert: Stability thief found, relanding speculative reverts. Original issue's description: > Revert of Preparse inner functions (new try) (patchset #21 id:420001 of https://codereview.chromium.org/2352593002/ ) > > Reason for revert: > We currently have some stability issues on Canary. Let's reland this after we verified that we "fixed" Canary again. > > Original issue's description: > > Preparse inner functions (new try) > > > > This is an overly pessimistic approach where PreParser only keeps > > track of unresolved variables, but doesn't declare anything. This > > will result in context-allocating variables in the outer function > > unnecessarily, if the variable names clash with variable names > > used by the inner function (even if the variables are not the > > same). However, we have been unable to prove that this approach > > wouldn't be good enough for the practical purposes. > > > > Fixes after the previous try ( https://codereview.chromium.org/2322243002/ ): > > Keep the context-allocation decision stable when compiling fully eagerly. > > > > Tests which exercise this functionality: > > mjsunit/fixed-context-shapes-when-recompiling.js > > > > Design document (chromium): > > > > https://docs.google.com/a/chromium.org/document/d/1rRv5JJZ0JpOZAZN2CSUwZPFJiBAdRnTiSYhazseNHFg/edit?usp=sharing > > > > BUG= > > > > Committed: https://crrev.com/7c73cf32c60484cdf37c84f1d61b4640e87068d7 > > Cr-Commit-Position: refs/heads/master@{#39719} > > TBR=verwaest@chromium.org,adamk@chromium.org,marja@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/1e6296b2a7cfc307fd9e722e619f42965da4a267 > Cr-Commit-Position: refs/heads/master@{#39730} TBR=verwaest@chromium.org,adamk@chromium.org,marja@chromium.org,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1f9863aa1819a94a01ddd283fba193f4c283b94f Cr-Commit-Position: refs/heads/master@{#39755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -100 lines) Patch
M src/ast/scopes.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ast/scopes.cc View 6 chunks +40 lines, -10 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 13 chunks +85 lines, -41 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/parsing/preparser.h View 6 chunks +15 lines, -13 lines 0 comments Download
M src/parsing/preparser.cc View 4 chunks +46 lines, -16 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +9 lines, -1 line 0 comments Download
M test/mjsunit/debug-function-scopes.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-scopes.js View 2 chunks +11 lines, -11 lines 0 comments Download
A test/mjsunit/lazy-inner-functions.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Camillo Bruni
Created Reland of Preparse inner functions (new try)
4 years, 2 months ago (2016-09-27 09:47:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377513006/1
4 years, 2 months ago (2016-09-27 09:48:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 09:48:24 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 09:48:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f9863aa1819a94a01ddd283fba193f4c283b94f
Cr-Commit-Position: refs/heads/master@{#39755}

Powered by Google App Engine
This is Rietveld 408576698