Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 23775007: Fix multiple V8::Dispose calls since r16563. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix multiple V8::Dispose calls since r16563. R=svenpanne@chromium.org BUG=v8:2744 TEST=cctest/test-api/InitializeAndDisposeMultiple Committed: http://code.google.com/p/v8/source/detail?r=16565

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.cc View 3 chunks +12 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-06 08:29:34 UTC) #1
Sven Panne
LGTM (probably ;-) https://codereview.chromium.org/23775007/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/23775007/diff/1/src/v8.cc#newcode103 src/v8.cc:103: Isolate::SetIsolateThreadLocals(isolate, NULL); This looks a bit ...
7 years, 3 months ago (2013-09-06 10:48:27 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-09-06 11:03:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16565.

Powered by Google App Engine
This is Rietveld 408576698