Issue 23775007: Fix multiple V8::Dispose calls since r16563.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23775007: Fix multiple V8::Dispose calls since r16563. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix multiple V8::Dispose calls since r16563. R=svenpanne@chromium.org BUG=v8:2744 TEST=cctest/test-api/InitializeAndDisposeMultiple Committed: http://code.google.com/p/v8/source/detail?r=16565

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/isolate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/v8.cc	View		3 chunks	+12 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM (probably ;-) https://codereview.chromium.org/23775007/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/23775007/diff/1/src/v8.cc#newcode103 src/v8.cc:103: Isolate::SetIsolateThreadLocals(isolate, NULL); This looks a bit ...

7 years, 3 months ago (2013-09-06 10:48:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r16565.

Expand Messages | Collapse Messages