SkPDF/Documentation: backend limitations

SkPDF/Documentation: backend limitations

NOTRY=true

Committed: https://skia.googlesource.com/skia/+/919f21f877a42b8c50531bcf813d7a1bc212f13c

[hal.canary, 2016-09-26 20:58:14]

Description was changed from

==========
SkPDF/Documentation: backend limitations

.
==========

to

==========
SkPDF/Documentation: backend limitations

.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377473002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2377473002
==========

[hal.canary, 2016-09-26 21:00:53]

Description was changed from

==========
SkPDF/Documentation: backend limitations

.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377473002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2377473002
==========

to

==========
SkPDF/Documentation: backend limitations

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=2377473002#limits
==========

[hal.canary, 2016-09-26 21:10:44]

halcanary@google.com changed reviewers:
+ djsollen@google.com

[hal.canary, 2016-09-26 21:10:45]

PTAL

[hal.canary, 2016-09-27 15:12:49]

Description was changed from

==========
SkPDF/Documentation: backend limitations

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=2377473002#limits
==========

to

==========
SkPDF/Documentation: backend limitations

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=2377473002#limits
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377473002
==========

[djsollen, 2016-09-29 13:12:40]

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.md
File site/user/sample/pdf.md (right):

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:48: There are several corners of Skia's public API that
SkPDF does not
SkPDF currently does not

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:49: handle because either no one has asked for it or
there is no simple
replace "no one has asked for it" with "no known client uses the feature"

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:52: **drop** means to draw nothing.
put a heading above these 3 terms indicating they are a glossary of sorts.

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:56: **expand** means to implement something in a
non-PDF-ish way.
does non-PDF-ish mean rasterized content instead of vector?

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:58: - *SkMaskFilter* — Mask filters are either dropped
(drawText calls)
these first 3 bullets  (and the last one) say the same thing as the table so I
wouldn't include them here.

[hal.canary, 2016-09-29 15:31:13]

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.md
File site/user/sample/pdf.md (right):

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:48: There are several corners of Skia's public API that
SkPDF does not
On 2016/09/29 13:12:39, djsollen wrote:
> SkPDF currently does not

Done.

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:49: handle because either no one has asked for it or
there is no simple
On 2016/09/29 13:12:40, djsollen wrote:
> replace "no one has asked for it" with "no known client uses the feature"

Done.

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:52: **drop** means to draw nothing.
On 2016/09/29 13:12:40, djsollen wrote:
> put a heading above these 3 terms indicating they are a glossary of sorts.

Done.

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:56: **expand** means to implement something in a
non-PDF-ish way.
On 2016/09/29 13:12:40, djsollen wrote:
> does non-PDF-ish mean rasterized content instead of vector?

Done.

  + **expand** means to implement something in a non-PDF-ish way.
    This may mean to rasterize vector graphics, to expand paths with
    path effects into many individual paths, or to convert text to
    paths.

https://codereview.chromium.org/2377473002/diff/160001/site/user/sample/pdf.m...
site/user/sample/pdf.md:58: - *SkMaskFilter* — Mask filters are either dropped
(drawText calls)
On 2016/09/29 13:12:39, djsollen wrote:
> these first 3 bullets  (and the last one) say the same thing as the table so I
> wouldn't include them here.

Done.

[djsollen, 2016-09-29 15:38:22]

lgtm

[hal.canary, 2016-09-29 15:42:22]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-09-29 15:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-09-29 15:43:01]

Description was changed from

==========
SkPDF/Documentation: backend limitations

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=2377473002#limits
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377473002
==========

to

==========
SkPDF/Documentation: backend limitations

NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-29 15:43:43]

Description was changed from

==========
SkPDF/Documentation: backend limitations

NOTRY=true
==========

to

==========
SkPDF/Documentation: backend limitations

NOTRY=true

Committed:
https://skia.googlesource.com/skia/+/919f21f877a42b8c50531bcf813d7a1bc212f13c
==========

[commit-bot: I haz the power, 2016-09-29 15:43:44]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/919f21f877a42b8c50531bcf813d7a1bc212f13c