Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: ui/accessibility/ax_tree.cc

Issue 2377443002: Fix another bug in AXTree caught by libfuzzer (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/accessibility/ax_tree_unittest.cc » ('j') | ui/accessibility/ax_tree_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/ax_tree.cc
diff --git a/ui/accessibility/ax_tree.cc b/ui/accessibility/ax_tree.cc
index ddf04d01ad9f31884a474fbffec1e70120044301..1d6cc234d9a46645f24b0d137b4c2843201370eb 100644
--- a/ui/accessibility/ax_tree.cc
+++ b/ui/accessibility/ax_tree.cc
@@ -248,7 +248,8 @@ bool AXTree::UpdateNode(const AXNodeData& src,
root_ = nullptr;
DestroySubtree(old_root, update_state);
- if (node != old_root &&
aboxhall 2016/09/26 20:24:44 Why is this no longer necessary?
dmazzoni 2016/09/27 20:19:26 See next comment
+ if (update_state->removed_node_ids.find(src.id) ==
aboxhall 2016/09/26 20:24:44 Can you describe what this is doing in more detail
dmazzoni 2016/09/27 20:19:26 Updated change description and added comments to c
+ update_state->removed_node_ids.end() &&
update_state->new_nodes.find(node) != update_state->new_nodes.end()) {
DestroySubtree(node, update_state);
}
« no previous file with comments | « no previous file | ui/accessibility/ax_tree_unittest.cc » ('j') | ui/accessibility/ax_tree_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698