Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2377383003: MD History: Round down timestamp used for incremental queries (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Round down timestamp used for incremental queries This ensures that results from incremental queries are strictly older than existing results, while retaining millisecond accuracy. This is equivelant behavior to the old History page, which rounds down the timestamp using new Date(). BUG=651677 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2d556f1183c63ea3cda2f21dfe64187c885c9a32 Cr-Commit-Position: refs/heads/master@{#422035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
tsergeant
open the door run Math.floor() everybody walk the dinosaur
4 years, 2 months ago (2016-09-30 04:11:14 UTC) #3
calamity
───────────────────── ───────────████████── ──────────███▄███████ ──────────███████████ ──────────███████████ ──────────██████───── lgtm. i guess. ──────────█████████── █───────███████────── ██────████████████─── ███──██████████──█─── ███████████████────── ███████████████────── ...
4 years, 2 months ago (2016-09-30 04:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377383003/1
4 years, 2 months ago (2016-09-30 04:45:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 05:38:38 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 05:40:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d556f1183c63ea3cda2f21dfe64187c885c9a32
Cr-Commit-Position: refs/heads/master@{#422035}

Powered by Google App Engine
This is Rietveld 408576698