Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 2377373002: Add netconfigs for different network type (Closed)
Patch Set: Update test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | telemetry/telemetry/page/traffic_setting.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/shared_page_state.py
diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py
index c6723784519446055f181b0189fd78bfbb933263..1f14ab1b308fe18bb77b42c114799769f84d3234 100644
--- a/telemetry/telemetry/page/shared_page_state.py
+++ b/telemetry/telemetry/page/shared_page_state.py
@@ -252,8 +252,11 @@ class SharedPageState(story.SharedState):
cache_temperature.EnsurePageCacheTemperature(
self._current_page, self.browser, self._previous_page)
if self._current_page.traffic_setting != traffic_setting.NONE:
- # TODO(kouhei): fill in appropriate traffic shaping data.
- raise NotImplementedError()
+ s = traffic_setting.NETWORK_CONFIGS[self._current_page.traffic_setting]
+ self.platform.network_controller.UpdateTrafficSettings(
+ round_trip_latency_ms=s.round_trip_latency_ms,
+ download_bandwidth_kbps=s.download_bandwidth_kbps,
+ upload_bandwidth_kbps=s.upload_bandwidth_kbps)
# Start profiling if needed.
if self._finder_options.profiler:
« no previous file with comments | « telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | telemetry/telemetry/page/traffic_setting.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698