Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by Jarin Modified:
4 years, 2 months ago Reviewers:
Michael Starzinger CC:
v8-reviews_googlegroups.com, rmcilroy Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Explicit OSR environment merge for bytecode graph builder.
Committed: https://crrev.com/fb7904c6dcfad9f12b7740579692b89a43334a03
Cr-Commit-Position: refs/heads/master@{#39875}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comment #
Created: 4 years, 2 months ago
Messages
Total messages: 14 (8 generated)
The CQ bit was checked by jarin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jarin@chromium.org changed reviewers: + mstarzinger@chromium.org
Could you take a look, please?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, just one comment to address. https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph... File src/compiler/bytecode-graph-builder.cc (left): https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph... src/compiler/bytecode-graph-builder.cc:414: DCHECK_EQ(1, GetControlDependency()->InputCount()); Please preserve these two asserts inside {BuildOSRLoopEntryPoint} on the {loop_env} there. They saved my behind several times already. :)
https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph... File src/compiler/bytecode-graph-builder.cc (left): https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph... src/compiler/bytecode-graph-builder.cc:414: DCHECK_EQ(1, GetControlDependency()->InputCount()); On 2016/09/29 14:29:32, Michael Starzinger wrote: > Please preserve these two asserts inside {BuildOSRLoopEntryPoint} on the > {loop_env} there. They saved my behind several times already. :) Done.
The CQ bit was checked by jarin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/2377343002/#ps20001 (title: "Address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Explicit OSR environment merge for bytecode graph builder. ========== to ========== [turbofan] Explicit OSR environment merge for bytecode graph builder. Committed: https://crrev.com/fb7904c6dcfad9f12b7740579692b89a43334a03 Cr-Commit-Position: refs/heads/master@{#39875} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fb7904c6dcfad9f12b7740579692b89a43334a03 Cr-Commit-Position: refs/heads/master@{#39875} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
