[turbofan] Explicit OSR environment merge for bytecode graph builder.

[turbofan] Explicit OSR environment merge for bytecode graph builder.

Committed: https://crrev.com/fb7904c6dcfad9f12b7740579692b89a43334a03
Cr-Commit-Position: refs/heads/master@{#39875}

[Jarin, 2016-09-29 13:45:59]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 13:46:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-09-29 13:47:21]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2016-09-29 13:47:21]

Could you take a look, please?

[commit-bot: I haz the power, 2016-09-29 14:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 14:12:03]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-09-29 14:29:32]

LGTM, just one comment to address.

https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (left):

https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:414: DCHECK_EQ(1,
GetControlDependency()->InputCount());
Please preserve these two asserts inside {BuildOSRLoopEntryPoint} on the
{loop_env} there. They saved my behind several times already. :)

[Jarin, 2016-09-29 14:32:54]

https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (left):

https://codereview.chromium.org/2377343002/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:414: DCHECK_EQ(1,
GetControlDependency()->InputCount());
On 2016/09/29 14:29:32, Michael Starzinger wrote:
> Please preserve these two asserts inside {BuildOSRLoopEntryPoint} on the
> {loop_env} there. They saved my behind several times already. :)

Done.

[Jarin, 2016-09-29 14:32:58]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-09-29 14:32:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2377343002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-09-29 14:33:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 15:14:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-29 15:14:55]

Description was changed from

==========
[turbofan] Explicit OSR environment merge for bytecode graph builder.
==========

to

==========
[turbofan] Explicit OSR environment merge for bytecode graph builder.

Committed: https://crrev.com/fb7904c6dcfad9f12b7740579692b89a43334a03
Cr-Commit-Position: refs/heads/master@{#39875}
==========

[commit-bot: I haz the power, 2016-09-29 15:14:57]

Patchset 2 (id:??) landed as
https://crrev.com/fb7904c6dcfad9f12b7740579692b89a43334a03
Cr-Commit-Position: refs/heads/master@{#39875}