Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2377333002: Site Settings Desktop: Use 'actionable' more throughout. (Closed)

Created:
4 years, 2 months ago by Finnur
Modified:
4 years, 2 months ago
Reviewers:
dschuyler, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Use 'actionable' more throughout. BUG=633973 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cbae8a3c1820a607f2d60f84a9c2645298dc47f5 Cr-Commit-Position: refs/heads/master@{#422065}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/resources/settings/site_settings/protocol_handlers.html View 1 chunk +4 lines, -3 lines 1 comment Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Finnur
4 years, 2 months ago (2016-09-29 13:25:11 UTC) #4
Dan Beam
lgtm https://codereview.chromium.org/2377333002/diff/1/chrome/browser/resources/settings/site_settings/protocol_handlers.html File chrome/browser/resources/settings/site_settings/protocol_handlers.html (right): https://codereview.chromium.org/2377333002/diff/1/chrome/browser/resources/settings/site_settings/protocol_handlers.html#newcode61 chrome/browser/resources/settings/site_settings/protocol_handlers.html:61: actionable> damn, I didn't add actionable in these ...
4 years, 2 months ago (2016-09-29 17:41:14 UTC) #6
dschuyler
lgtm
4 years, 2 months ago (2016-09-29 19:43:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377333002/1
4 years, 2 months ago (2016-09-30 07:37:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 08:23:13 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 08:25:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbae8a3c1820a607f2d60f84a9c2645298dc47f5
Cr-Commit-Position: refs/heads/master@{#422065}

Powered by Google App Engine
This is Rietveld 408576698