Issue 23773003: dump out sizeof(void*) in header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23773003: dump out sizeof(void*) in header (Closed)

Created:
7 years, 3 months ago by reed1

Modified:
7 years, 3 months ago

Reviewers:
bungeman-skia, rmistry

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

dump out sizeof(void*) in header BUG= R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=11012

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/skia_test.cpp	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

https://codereview.chromium.org/23773003/diff/1/tests/skia_test.cpp File tests/skia_test.cpp (right): https://codereview.chromium.org/23773003/diff/1/tests/skia_test.cpp#newcode199 tests/skia_test.cpp:199: header.appendf(" skia_arch_width=%d", (int)sizeof(void*) * 8); 8? Not CHAR_BIT (its ...

7 years, 3 months ago (2013-08-29 20:07:21 UTC) #3

reed1

7 years, 3 months ago (2013-08-29 20:20:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11012 (presubmit successful).

Expand Messages | Collapse Messages