Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2377273002: [heap] Always use getter when accessing MarkingDeque (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Always use getter when accessing MarkingDeque BUG=chromium:651354 Committed: https://crrev.com/9b7264e30da9699da9a7dceb95befb901ce56b20 Cr-Commit-Position: refs/heads/master@{#39859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
ptal; after this we can easily swap out the MarkingDeque
4 years, 2 months ago (2016-09-29 10:43:05 UTC) #7
ulan
lgtm
4 years, 2 months ago (2016-09-29 10:51:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377273002/1
4 years, 2 months ago (2016-09-29 10:52:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 10:56:11 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 10:56:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b7264e30da9699da9a7dceb95befb901ce56b20
Cr-Commit-Position: refs/heads/master@{#39859}

Powered by Google App Engine
This is Rietveld 408576698