Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2377253002: Add explicit to core/fetch, core/loader and modules/websockets (Closed)

Created:
4 years, 2 months ago by hiroshige
Modified:
4 years, 2 months ago
Reviewers:
haraken, yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add explicit to core/fetch, core/loader and modules/websockets BUG=645395 Committed: https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17 Cr-Commit-Position: refs/heads/master@{#422047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M third_party/WebKit/Source/core/fetch/DocumentResourceReference.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/LinkFetchResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/SinkDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/SinkDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
hiroshige
PTAL.
4 years, 2 months ago (2016-09-29 10:47:42 UTC) #2
haraken
LGTM
4 years, 2 months ago (2016-09-29 11:20:03 UTC) #3
yhirano
lgtm
4 years, 2 months ago (2016-09-30 02:02:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377253002/1
4 years, 2 months ago (2016-09-30 05:09:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 06:44:07 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 06:45:59 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17
Cr-Commit-Position: refs/heads/master@{#422047}

Powered by Google App Engine
This is Rietveld 408576698