Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2377243003: Make VirtualTimeTest fast (Closed)

Created:
4 years, 2 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 2 months ago
Reviewers:
Mike West, Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VirtualTimeTest fast The SimTest destructor calls runPendingTasks. This is a problem for the VirtualTimeTest because if there are any repeating timers, advancing virtual time causes the runloop to busy loop. Pausing virtual time in the test TearDown fixes that. BUG=650340 Committed: https://crrev.com/bb0215b1d3e241a44bf4257632608b81758fc6ae Cr-Commit-Position: refs/heads/master@{#421800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alex clarke (OOO till 29th)
PTAL
4 years, 2 months ago (2016-09-29 10:32:35 UTC) #4
Sami
lgtm.
4 years, 2 months ago (2016-09-29 10:35:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377243003/1
4 years, 2 months ago (2016-09-29 10:35:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 11:32:14 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 11:34:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb0215b1d3e241a44bf4257632608b81758fc6ae
Cr-Commit-Position: refs/heads/master@{#421800}

Powered by Google App Engine
This is Rietveld 408576698