third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h - Issue 2377243002: Add support for CSSValue->CSSSimpleLength when it is a percentage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h

Issue 2377243002: Add support for CSSValue->CSSSimpleLength when it is a percentage. (Closed)

Patch Set: Update test expectations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h b/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h

index 18ec13bf70114c288f8109c138e54d35f52d6340..1e3da092281d29b07d46d63546560129f37d178d 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h

@@ -26,7 +26,7 @@ public:

bool containsPercent() const override;

double value() const { return m_value; }

- String unit() const { return String(CSSPrimitiveValue::unitTypeToString(m_unit)); }

+ String unit() const;

CSSPrimitiveValue::UnitType lengthUnit() const { return m_unit; }

StyleValueType type() const override { return StyleValueType::SimpleLengthType; }