Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 237723004: Move EventBindings to //extensions (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move EventBindings to //extensions This moves the EventBindings class to //extensions along with one of its dependencies (ValueCounter). EventBindings::Create now returns an ObjectBackedNativeHandler rather than a ChromeV8Extension. BUG=359836 TBR=phajdan.jr@chromium.org for chrome/test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -596 lines) Patch
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/value_counter.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/common/extensions/value_counter.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/common/extensions/value_counter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/renderer/extensions/event_bindings.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/renderer/extensions/event_bindings.cc View 1 chunk +0 lines, -338 lines 0 comments Download
M chrome/renderer/extensions/messaging_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 2 chunks +1 line, -1 line 0 comments Download
A + extensions/common/value_counter.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/common/value_counter.cc View 1 chunk +10 lines, -21 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + extensions/renderer/event_bindings.h View 1 chunk +7 lines, -8 lines 0 comments Download
A + extensions/renderer/event_bindings.cc View 12 chunks +39 lines, -53 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ken Rockot(use gerrit already)
Yoyo could you please take a look at this?
6 years, 8 months ago (2014-04-14 23:47:52 UTC) #1
Yoyo Zhou
LGTM
6 years, 8 months ago (2014-04-15 00:22:29 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-15 00:24:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/237723004/1
6 years, 8 months ago (2014-04-15 00:24:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 07:50:30 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-15 07:50:30 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-15 16:37:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/237723004/1
6 years, 8 months ago (2014-04-15 16:39:22 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 18:20:29 UTC) #9
Message was sent while issue was closed. 
Change committed as 263928

Powered by Google App Engine
This is Rietveld 408576698