Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2377203003: [heap] Remove unnecessary marking specializations (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unnecessary marking specializations R=hpayer@chromium.org BUG=chromium:651828 Committed: https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7 Cr-Commit-Position: refs/heads/master@{#39917}

Patch Set 1 : PropertyCell #

Patch Set 2 : AllocationSite #

Patch Set 3 : VisitJSRegexp #

Patch Set 4 : BytecodeArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M src/heap/incremental-marking.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/objects-visiting.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 3 5 chunks +12 lines, -47 lines 0 comments Download
M src/objects.h View 1 2 3 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Michael Lippautz
ptal
4 years, 2 months ago (2016-09-29 14:02:21 UTC) #4
Hannes Payer (out of office)
lgtm
4 years, 2 months ago (2016-09-30 13:48:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377203003/80001
4 years, 2 months ago (2016-09-30 13:52:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377203003/80001
4 years, 2 months ago (2016-09-30 13:55:00 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 2 months ago (2016-09-30 13:57:35 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 13:57:53 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7
Cr-Commit-Position: refs/heads/master@{#39917}

Powered by Google App Engine
This is Rietveld 408576698