third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2377193004: [DevTools] Rework some focus code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2377193004: [DevTools] Rework some focus code. (Closed)

Patch Set: fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/Spectrum.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | third_party/WebKit/Source/devtools/front_end/externs.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index 0ffff8c502d6400ad898ff2c48a2d9da3d7e3788..aff56bf5ba6c46fbff855747f3584727d182677d 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -332,7 +332,6 @@ WebInspector.ConsoleView.prototype = {

wasShown: function()

{

this._viewport.refresh();

- this.focus();

einbinder 2016/09/30 19:37:52 Why does this get removed? Is the prompt still foc

dgozman 2016/09/30 20:27:19 Yes, the proper way of hierarchical focus() calls

focus: function()