third_party/WebKit/LayoutTests/media/track/track-cue-rendering-transformed-video.html - Issue 2377193003: Don't use absolute bounding boxes in LayoutVTTCue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-transformed-video.html

Issue 2377193003: Don't use absolute bounding boxes in LayoutVTTCue (Closed)

Patch Set: Add test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-transformed-video-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../media-file.js"></script>

	3 <style>

	4 video {

	5 transform: translate(1px, 0px);
	foolip 2016/09/29 19:25:19 Haha, no more than necessary to test :) Haha, no more than necessary to test :)
	6 }

	7 video::cue {

	8 font-size: 50px;

	9 color: green;

	10 background-color: green;

	11 }

	12 </style>

	13 <video>

	14 <script>

	15 var video = document.currentScript.parentNode;
	foolip 2016/09/29 19:25:19 AFAICT the test doesn't require the script to be i AFAICT the test doesn't require the script to be inside the video element, right? Looks like some of the other tests here have it because there are multiple video elements, but for this I'd wonder if it's trying to tickle some corner case like https://bugs.chromium.org/p/chromium/issues/detail?id=350303 fs 2016/09/29 19:40:08 No, before 'load' should do I guess. I can "unwrap Show quoted text On 2016/09/29 at 19:25:19, foolip wrote: > AFAICT the test doesn't require the script to be inside the video element, right? Looks like some of the other tests here have it because there are multiple video elements, but for this I'd wonder if it's trying to tickle some corner case like https://bugs.chromium.org/p/chromium/issues/detail?id=350303 No, before 'load' should do I guess. I can "unwrap" the <video> (to <video></video><script>...) foolip 2016/09/29 19:49:33 SGTM Show quoted text On 2016/09/29 19:40:08, fs wrote: > On 2016/09/29 at 19:25:19, foolip wrote: > > AFAICT the test doesn't require the script to be inside the video element, > right? Looks like some of the other tests here have it because there are > multiple video elements, but for this I'd wonder if it's trying to tickle some > corner case like https://bugs.chromium.org/p/chromium/issues/detail?id=350303 > > No, before 'load' should do I guess. I can "unwrap" the <video> (to > <video></video><script>...) SGTM fs 2016/09/30 08:05:32 Done. Show quoted text On 2016/09/29 at 19:49:33, foolip wrote: > On 2016/09/29 19:40:08, fs wrote: > > On 2016/09/29 at 19:25:19, foolip wrote: > > > AFAICT the test doesn't require the script to be inside the video element, > > right? Looks like some of the other tests here have it because there are > > multiple video elements, but for this I'd wonder if it's trying to tickle some > > corner case like https://bugs.chromium.org/p/chromium/issues/detail?id=350303 > > > > No, before 'load' should do I guess. I can "unwrap" the <video> (to > > <video></video><script>...) > > SGTM Done.
	16 var track = video.addTextTrack('subtitles');

	17 var cue = new VTTCue(0, 10, 'XXX');

	18 cue.align = 'start';

	19 cue.line = 0;

	20 track.addCue(cue);

	21 track.mode = 'showing';

	22 video.src = findMediaFile('video', '../content/test');

	23 </script>

	24 </video>

OLD	NEW