Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2377183002: Add paint property path printers and test them (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add paint property path printers and test them This patch is a followup to [1] and restores the old paint property tree path printers. Additionally, simple tests have been added to ensure they do not break. [1] https://crrev.com/a08dcd0cb471c6f7bced2291892bc1008aaa8890 BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/e61b7c42641360ac6085b7667370cb2e58b4cad2 Cr-Commit-Position: refs/heads/master@{#421727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h View 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 2 chunks +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
4 years, 2 months ago (2016-09-29 01:16:23 UTC) #3
Xianzhu
lgtm. Thanks!
4 years, 2 months ago (2016-09-29 01:19:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377183002/1
4 years, 2 months ago (2016-09-29 02:44:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 02:50:24 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 02:53:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e61b7c42641360ac6085b7667370cb2e58b4cad2
Cr-Commit-Position: refs/heads/master@{#421727}

Powered by Google App Engine
This is Rietveld 408576698