Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: content/renderer/media/video_capture_impl_manager_unittest.cc

Issue 2377163002: VideoCaptureImpl cleanup: merge ctor+Init() and DeInit()+dtor. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_capture_impl_manager_unittest.cc
diff --git a/content/renderer/media/video_capture_impl_manager_unittest.cc b/content/renderer/media/video_capture_impl_manager_unittest.cc
index 349a32eca34dd43331fda673b53267c1fae1ed56..93a614da6dab0de9b4e256380793d496673842fa 100644
--- a/content/renderer/media/video_capture_impl_manager_unittest.cc
+++ b/content/renderer/media/video_capture_impl_manager_unittest.cc
@@ -32,14 +32,15 @@ class MockVideoCaptureImpl : public VideoCaptureImpl {
MockVideoCaptureImpl(media::VideoCaptureSessionId session_id,
VideoCaptureMessageFilter* filter,
base::Closure destruct_callback)
- : VideoCaptureImpl(session_id, filter),
- destruct_callback_(destruct_callback) {
- }
+ : VideoCaptureImpl(session_id,
+ filter,
+ ChildProcess::current()->io_task_runner()),
+ destruct_callback_(destruct_callback) {}
~MockVideoCaptureImpl() override { destruct_callback_.Run(); }
private:
- base::Closure destruct_callback_;
+ const base::Closure destruct_callback_;
DISALLOW_COPY_AND_ASSIGN(MockVideoCaptureImpl);
};
@@ -62,7 +63,7 @@ class MockVideoCaptureImplManager : public VideoCaptureImplManager {
}
private:
- base::Closure destruct_video_capture_callback_;
+ const base::Closure destruct_video_capture_callback_;
DISALLOW_COPY_AND_ASSIGN(MockVideoCaptureImplManager);
};
@@ -70,11 +71,12 @@ class MockVideoCaptureImplManager : public VideoCaptureImplManager {
class VideoCaptureImplManagerTest : public ::testing::Test {
public:
VideoCaptureImplManagerTest()
- : manager_(new MockVideoCaptureImplManager(
- BindToCurrentLoop(cleanup_run_loop_.QuitClosure()))) {
+ : child_process_(new ChildProcess()),
+ manager_(new MockVideoCaptureImplManager(
+ BindToCurrentLoop(cleanup_run_loop_.QuitClosure()))) {
params_.requested_format = media::VideoCaptureFormat(
gfx::Size(176, 144), 30, media::PIXEL_FORMAT_I420);
- child_process_.reset(new ChildProcess());
+ ;
}
void FakeChannelSetup() {
@@ -117,8 +119,8 @@ class VideoCaptureImplManagerTest : public ::testing::Test {
base::Unretained(this)));
}
- base::MessageLoop message_loop_;
- std::unique_ptr<ChildProcess> child_process_;
+ const base::MessageLoop message_loop_;
+ const std::unique_ptr<ChildProcess> child_process_;
media::VideoCaptureParams params_;
base::RunLoop cleanup_run_loop_;
std::unique_ptr<MockVideoCaptureImplManager> manager_;

Powered by Google App Engine
This is Rietveld 408576698