Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2377143002: Implement weak pointers (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Implement weak pointers These will be a replacement for CFX_CountRef in future CLs, since CFX_CountRef is manually incremented and error-prone. Committed: https://pdfium.googlesource.com/pdfium/+/4ba37c6f6964f6a24fc4b8b48bc82c02edb70370

Patch Set 1 #

Patch Set 2 : Fix TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A core/fxcrt/cfx_weak_ptr_unittest.cpp View 1 chunk +174 lines, -0 lines 0 comments Download
A core/fxcrt/include/cfx_weak_ptr.h View 1 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, for review.
4 years, 2 months ago (2016-09-28 20:36:22 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-09-28 21:35:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377143002/20001
4 years, 2 months ago (2016-09-28 21:38:08 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:49:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4ba37c6f6964f6a24fc4b8b48bc82c02edb7...

Powered by Google App Engine
This is Rietveld 408576698