Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2377113002: Set update gclient config with override deps. (Closed)

Created:
4 years, 2 months ago by RobertoCN
Modified:
4 years, 2 months ago
Reviewers:
prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Set update gclient config with override deps. The purpose of this change is to make the bot_update step check out the appropriate deps revisions when bisecting into rolls, this is the step that runs locally on the bisect bot prior to unzipping the image with the build. R=prasadv BUG=649825 Committed: https://chromium.googlesource.com/chromium/tools/build/+/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -25 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/revision_state.py View 4 chunks +21 lines, -25 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 4 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 4 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
RobertoCN
Prasad, do you think this change will fix the current problem? (See bug)
4 years, 2 months ago (2016-09-28 20:08:58 UTC) #1
prasadv
lgtm
4 years, 2 months ago (2016-09-28 21:06:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377113002/1
4 years, 2 months ago (2016-09-28 21:37:22 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:44:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/cb44b4ffbeeff3c92845...

Powered by Google App Engine
This is Rietveld 408576698