Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: test/upgrade/git/do_not_upgrade_if_unneeded_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unknown_source_test.dart ('k') | test/upgrade/git/upgrade_locked_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/upgrade/git/do_not_upgrade_if_unneeded_test.dart
diff --git a/test/upgrade/git/do_not_upgrade_if_unneeded_test.dart b/test/upgrade/git/do_not_upgrade_if_unneeded_test.dart
index 69459c7cfbee26e156d37681afe569ee76996b0b..c05a6309ea754b264708d2b65b338abe61391d3e 100644
--- a/test/upgrade/git/do_not_upgrade_if_unneeded_test.dart
+++ b/test/upgrade/git/do_not_upgrade_if_unneeded_test.dart
@@ -24,7 +24,9 @@ main() {
d.appDir({"foo": {"git": "../foo.git"}}).create();
- pubGet();
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubGet(args: ["--packages-dir"]);
d.dir(packagesPath, [
d.dir('foo', [
@@ -47,7 +49,9 @@ main() {
d.libPubspec('foo_dep', '1.0.0')
]).commit();
- pubUpgrade(args: ['foo']);
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubUpgrade(args: ["--packages-dir", 'foo']);
d.dir(packagesPath, [
d.dir('foo', [
« no previous file with comments | « test/unknown_source_test.dart ('k') | test/upgrade/git/upgrade_locked_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698