Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: test/get/git/locked_revision_without_repo_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/get/git/lock_version_test.dart ('k') | test/get/git/stay_locked_if_compatible_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/get/git/locked_revision_without_repo_test.dart
diff --git a/test/get/git/locked_revision_without_repo_test.dart b/test/get/git/locked_revision_without_repo_test.dart
index 69e918edd9fba4d9a2394e466226fb3157406d5d..dc1ec599a85d1c83f40ce2fe5b2ad5cbc59a55ba 100644
--- a/test/get/git/locked_revision_without_repo_test.dart
+++ b/test/get/git/locked_revision_without_repo_test.dart
@@ -23,7 +23,9 @@ main() {
d.appDir({"foo": {"git": "../foo.git"}}).create();
// This get should lock the foo.git dependency to the current revision.
- pubGet();
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubGet(args: ["--packages-dir"]);
d.dir(packagesPath, [
d.dir('foo', [
@@ -42,7 +44,9 @@ main() {
]).commit();
// This get shouldn't upgrade the foo.git dependency due to the lockfile.
- pubGet();
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubGet(args: ["--packages-dir"]);
d.dir(packagesPath, [
d.dir('foo', [
« no previous file with comments | « test/get/git/lock_version_test.dart ('k') | test/get/git/stay_locked_if_compatible_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698