Chromium Code Reviews

Unified Diff: test/get/git/check_out_and_upgrade_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « test/get/broken_symlink_test.dart ('k') | test/get/git/check_out_branch_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/get/git/check_out_and_upgrade_test.dart
diff --git a/test/get/git/check_out_and_upgrade_test.dart b/test/get/git/check_out_and_upgrade_test.dart
index 670ee378dd499a75f4ec6b90a4cd3e9e84decf34..318403ba44385e8b69b5d54b2410b9c10307deca 100644
--- a/test/get/git/check_out_and_upgrade_test.dart
+++ b/test/get/git/check_out_and_upgrade_test.dart
@@ -18,7 +18,9 @@ main() {
d.appDir({"foo": {"git": "../foo.git"}}).create();
- pubGet();
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubGet(args: ["--packages-dir"]);
d.dir(cachePath, [
d.dir('git', [
@@ -38,7 +40,11 @@ main() {
d.libPubspec('foo', '1.0.0')
]).commit();
- pubUpgrade(output: contains("Changed 1 dependency!"));
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubUpgrade(
+ args: ["--packages-dir"],
+ output: contains("Changed 1 dependency!"));
// When we download a new version of the git package, we should re-use the
// git/cache directory but create a new git/ directory.
« no previous file with comments | « test/get/broken_symlink_test.dart ('k') | test/get/git/check_out_branch_test.dart » ('j') | no next file with comments »

Powered by Google App Engine