Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: test/downgrade/doesnt_change_git_dependencies_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../descriptor.dart' as d; 5 import '../descriptor.dart' as d;
6 import '../test_pub.dart'; 6 import '../test_pub.dart';
7 7
8 main() { 8 main() {
9 integration("doesn't change git dependencies", () { 9 integration("doesn't change git dependencies", () {
10 ensureGit(); 10 ensureGit();
11 11
12 d.git('foo.git', [ 12 d.git('foo.git', [
13 d.libDir('foo'), 13 d.libDir('foo'),
14 d.libPubspec('foo', '1.0.0') 14 d.libPubspec('foo', '1.0.0')
15 ]).create(); 15 ]).create();
16 16
17 d.appDir({ 17 d.appDir({
18 "foo": {"git": "../foo.git"} 18 "foo": {"git": "../foo.git"}
19 }).create(); 19 }).create();
20 20
21 pubGet(); 21 pubGet(args: ["--packages-dir"]);
nweiz 2016/09/28 20:01:21 Why not package root here? Same question for the o
Bob Nystrom 2016/09/29 00:21:26 We don't have an easy way of testing that a path i
22 22
23 d.dir(packagesPath, [ 23 d.dir(packagesPath, [
24 d.dir('foo', [ 24 d.dir('foo', [
25 d.file('foo.dart', 'main() => "foo";') 25 d.file('foo.dart', 'main() => "foo";')
26 ]) 26 ])
27 ]).validate(); 27 ]).validate();
28 28
29 d.git('foo.git', [ 29 d.git('foo.git', [
30 d.libDir('foo', 'foo 2'), 30 d.libDir('foo', 'foo 2'),
31 d.libPubspec('foo', '1.0.0') 31 d.libPubspec('foo', '1.0.0')
32 ]).commit(); 32 ]).commit();
33 33
34 pubDowngrade(); 34 pubDowngrade(args: ["--packages-dir"]);
35 35
36 d.dir(packagesPath, [ 36 d.dir(packagesPath, [
37 d.dir('foo', [ 37 d.dir('foo', [
38 d.file('foo.dart', 'main() => "foo";') 38 d.file('foo.dart', 'main() => "foo";')
39 ]) 39 ])
40 ]).validate(); 40 ]).validate();
41 }); 41 });
42 } 42 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698