Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: test/descriptor.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Pub-specific scheduled_test descriptors. 5 /// Pub-specific scheduled_test descriptors.
6 import 'package:oauth2/oauth2.dart' as oauth2; 6 import 'package:oauth2/oauth2.dart' as oauth2;
7 import 'package:pub/src/io.dart'; 7 import 'package:pub/src/io.dart';
8 import 'package:pub/src/utils.dart'; 8 import 'package:pub/src/utils.dart';
9 import 'package:scheduled_test/descriptor.dart'; 9 import 'package:scheduled_test/descriptor.dart';
10 import 'package:scheduled_test/scheduled_server.dart'; 10 import 'package:scheduled_test/scheduled_server.dart';
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 /// are located on disk. If the strings are semantic versions, then the packages 196 /// are located on disk. If the strings are semantic versions, then the packages
197 /// are located in the system cache; otherwise, the strings are interpreted as 197 /// are located in the system cache; otherwise, the strings are interpreted as
198 /// relative `file:` URLs. 198 /// relative `file:` URLs.
199 /// 199 ///
200 /// Validation checks that the `.packages` file exists, has the expected 200 /// Validation checks that the `.packages` file exists, has the expected
201 /// entries (one per key in [dependencies]), each with a path that contains 201 /// entries (one per key in [dependencies]), each with a path that contains
202 /// either the version string (for a reference to the pub cache) or a 202 /// either the version string (for a reference to the pub cache) or a
203 /// path to a path dependency, relative to the application directory. 203 /// path to a path dependency, relative to the application directory.
204 Descriptor packagesFile([Map<String, String> dependencies]) => 204 Descriptor packagesFile([Map<String, String> dependencies]) =>
205 new PackagesFileDescriptor(dependencies); 205 new PackagesFileDescriptor(dependencies);
206
207 /// Describes a `.packages` file in the application directory, including the
208 /// implicit entry for the app itself.
209 Descriptor appPackagesFile(Map<String, String> dependencies) {
210 var copied = new Map<String, String>.from(dependencies);
nweiz 2016/09/28 20:01:21 Are these type annotations required? I thought the
Bob Nystrom 2016/09/29 00:21:26 Doesn't seem like it. Would you rather I leave it
nweiz 2016/09/29 00:32:41 Yeah, that's what I do.
Bob Nystrom 2016/09/29 00:56:41 Done.
211 copied["myapp"] = ".";
212 return dir(appPath, [packagesFile(copied)]);
213 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698