Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2377043002: Fix TestCancelAuth_OnNavigation for PlzNavigation (Closed)

Created:
4 years, 2 months ago by vabr (Chromium)
Modified:
4 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, vabr+watchlistlogin_chromium.org, jam, sense (YandexTeam)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TestCancelAuth_OnNavigation for PlzNavigation LoginPromptBrowserTest.TestCancelAuth_OnNavigation expects 3 LOAD_STOP events for a sequence of: HTTP login interstitial, navigation to auth page, forced navigation to some other page. Under PlzNavigate, there is one less LOAD_STOP event due to not getting a LOAD_STOP for ongoing navigation when another one is triggered [1]. This CL adjusts the test to cope with PlzNavigate. [1] https://codereview.chromium.org/2371423002/#msg12 R=nasko@chromium.org BUG=648826 Committed: https://crrev.com/f8168f6ff165cb2bf59317284eaae2d04e2bc8a1 Cr-Commit-Position: refs/heads/master@{#421545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/login/login_handler_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vabr (Chromium)
Hi Nasko, PTAL. If you like the CL, please send it to the CQ, I'll ...
4 years, 2 months ago (2016-09-28 15:51:52 UTC) #1
vabr (Chromium)
I forgot to say that I reproduced the time-out locally, and the patch fixes it, ...
4 years, 2 months ago (2016-09-28 15:52:30 UTC) #4
nasko
LGTM
4 years, 2 months ago (2016-09-28 16:30:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377043002/1
4 years, 2 months ago (2016-09-28 16:34:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 16:46:02 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 16:49:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8168f6ff165cb2bf59317284eaae2d04e2bc8a1
Cr-Commit-Position: refs/heads/master@{#421545}

Powered by Google App Engine
This is Rietveld 408576698