Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2377033003: Revert "Rename CPDF_CountedObject to CFX_WeakPtr::Handle" (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Rename CPDF_CountedObject to CFX_WeakPtr::Handle" This reverts commit fe0179ded8202939ea4f2b92a879b8dede7821ea. This is blocking incremental revision, will try again. Committed: https://pdfium.googlesource.com/pdfium/+/8c41b1bf9fb7dd525f3a6b81d38f61d83500894d

Patch Set 1 #

Total comments: 2

Patch Set 2 : blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -74 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_countedobject.h View 1 chunk +47 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pattern.h View 2 chunks +0 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_colorspace.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 3 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_render/render_int.h View 2 chunks +3 lines, -3 lines 0 comments Download
D core/fxcrt/include/cfx_weak_ptr.h View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Tom Sepez
Lei, reversion.
4 years, 2 months ago (2016-09-28 19:18:06 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/2377033003/diff/1/core/fpdfapi/fpdf_page/include/cpdf_colorspace.h File core/fpdfapi/fpdf_page/include/cpdf_colorspace.h (left): https://codereview.chromium.org/2377033003/diff/1/core/fpdfapi/fpdf_page/include/cpdf_colorspace.h#oldcode9 core/fpdfapi/fpdf_page/include/cpdf_colorspace.h:9: accidental line deletion?
4 years, 2 months ago (2016-09-28 19:23:55 UTC) #6
Tom Sepez
https://codereview.chromium.org/2377033003/diff/1/core/fpdfapi/fpdf_page/include/cpdf_colorspace.h File core/fpdfapi/fpdf_page/include/cpdf_colorspace.h (left): https://codereview.chromium.org/2377033003/diff/1/core/fpdfapi/fpdf_page/include/cpdf_colorspace.h#oldcode9 core/fpdfapi/fpdf_page/include/cpdf_colorspace.h:9: On 2016/09/28 19:23:55, Lei Zhang wrote: > accidental line ...
4 years, 2 months ago (2016-09-28 20:10:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377033003/20001
4 years, 2 months ago (2016-09-28 20:10:17 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:21:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8c41b1bf9fb7dd525f3a6b81d38f61d83500...

Powered by Google App Engine
This is Rietveld 408576698