Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: src/compiler/x64/instruction-scheduler-x64.cc

Issue 2376963002: [turbofan] Relax dependencies due to deopt during instruction scheduling. (Closed)
Patch Set: fix formatting (git cl format) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction-scheduler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/x64/instruction-scheduler-x64.cc
diff --git a/src/compiler/x64/instruction-scheduler-x64.cc b/src/compiler/x64/instruction-scheduler-x64.cc
index 6311d86ed5f6f9648c2cba1e604c5bbaeee11f04..4208d8a5949c071c2c2d6b9895db31d43abe137e 100644
--- a/src/compiler/x64/instruction-scheduler-x64.cc
+++ b/src/compiler/x64/instruction-scheduler-x64.cc
@@ -36,10 +36,6 @@ int InstructionScheduler::GetTargetInstructionFlags(
case kX64Imul32:
case kX64ImulHigh32:
case kX64UmulHigh32:
- case kX64Idiv:
- case kX64Idiv32:
- case kX64Udiv:
- case kX64Udiv32:
case kX64Not:
case kX64Not32:
case kX64Neg:
@@ -133,6 +129,14 @@ int InstructionScheduler::GetTargetInstructionFlags(
? kNoOpcodeFlags
: kIsLoadOperation | kHasSideEffect;
+ case kX64Idiv:
+ case kX64Idiv32:
+ case kX64Udiv:
+ case kX64Udiv32:
+ return (instr->addressing_mode() == kMode_None)
+ ? kMayNeedDeoptCheck
+ : kMayNeedDeoptCheck | kIsLoadOperation | kHasSideEffect;
+
case kX64Movsxbl:
case kX64Movzxbl:
case kX64Movsxbq:
« no previous file with comments | « src/compiler/instruction-scheduler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698