Fix NULL dereference if a extension subpermission is removed.

Fix NULL dereference if a extension subpermission is removed.

Until recently, subpermissions where required to be correct, so this
issue shouldn't be hit in the wild.

BUG=363279
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263917

[Yoyo Zhou, 2014-04-14 23:21:53]

Consider adding a test to media_galleries_permission_unittest.cc too.

https://codereview.chromium.org/237693004/diff/1/extensions/common/permission...
File extensions/common/permissions/media_galleries_permission.cc (right):

https://codereview.chromium.org/237693004/diff/1/extensions/common/permission...
extensions/common/permissions/media_galleries_permission.cc:70: if
(unhandled_permissions) {
This also changes the behavior - I think it's more correct the way you have it.

[Yoyo Zhou, 2014-04-14 23:22:04]

(that should've been LGTM)

[vandebo (ex-Chrome), 2014-04-15 15:57:46]

On 2014/04/14 23:21:53, Yoyo Zhou wrote:
> Consider adding a test to media_galleries_permission_unittest.cc too.

Done and confirmed it repros the bug without the fix.

[vandebo (ex-Chrome), 2014-04-15 15:57:50]

The CQ bit was checked by vandebo@chromium.org

[commit-bot: I haz the power, 2014-04-15 15:58:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/237693004/20001

[commit-bot: I haz the power, 2014-04-15 17:57:38]

Change committed as 263917