Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/libaddressinput/chromium/cpp/src/rule.cc

Issue 237693002: requestAutocomplete should not unlatinize administrative region names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renames Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/src/rule.cc
diff --git a/third_party/libaddressinput/chromium/cpp/src/rule.cc b/third_party/libaddressinput/chromium/cpp/src/rule.cc
index 791ac9eca651bbba4d68945ffad93ffaafe454c4..1d5c4081517bfb41e64f1a9ce5f620fc3d70b1b8 100644
--- a/third_party/libaddressinput/chromium/cpp/src/rule.cc
+++ b/third_party/libaddressinput/chromium/cpp/src/rule.cc
@@ -197,6 +197,25 @@ int GetPostalCodeMessageId(const std::string& postal_code_type, bool error) {
return INVALID_MESSAGE_ID;
}
+// Finds |target| in |values_to_compare| and sets |selected_value| to the
+// associated value from |values_to_select|. Returns true if |target| is in
+// |values_to_compare|. |selected_value| should not be NULL. |values_to_compare|
+// should not be larger than |values_to_select|.
+bool GetMatchingValue(const std::string& target,
+ const std::vector<std::string>& values_to_compare,
+ const std::vector<std::string>& values_to_select,
+ std::string* selected_value) {
+ assert(selected_value != NULL);
+ assert(values_to_select.size() >= values_to_compare.size());
+ for (size_t i = 0; i < values_to_compare.size(); ++i) {
+ if (LooseStringCompare(values_to_compare[i], target)) {
+ *selected_value = values_to_select[i];
+ return true;
+ }
+ }
+ return false;
+}
+
} // namespace
FormatElement::FormatElement(AddressField field)
@@ -376,27 +395,20 @@ int Rule::GetInvalidFieldMessageId(AddressField field) const {
}
bool Rule::CanonicalizeSubKey(const std::string& user_input,
+ bool keep_input_latin,
std::string* sub_key) const {
+ assert(sub_key != NULL);
+
if (sub_keys_.empty()) {
*sub_key = user_input;
return true;
}
- return GetMatchingSubKey(user_input, sub_keys_, sub_key) ||
- GetMatchingSubKey(user_input, sub_names_, sub_key) ||
- GetMatchingSubKey(user_input, sub_lnames_, sub_key);
-}
-
-bool Rule::GetMatchingSubKey(const std::string& target,
- const std::vector<std::string>& values,
- std::string* sub_key) const {
- for (size_t i = 0; i < values.size(); ++i) {
- if (LooseStringCompare(values[i], target)) {
- *sub_key = sub_keys_[i];
- return true;
- }
- }
- return false;
+ return GetMatchingValue(user_input, sub_keys_, sub_keys_, sub_key) ||
+ GetMatchingValue(user_input, sub_names_, sub_keys_, sub_key) ||
+ (keep_input_latin &&
+ GetMatchingValue(user_input, sub_lnames_, sub_lnames_, sub_key)) ||
+ GetMatchingValue(user_input, sub_lnames_, sub_keys_, sub_key);
}
} // namespace addressinput

Powered by Google App Engine
This is Rietveld 408576698