third_party/libaddressinput/chromium/cpp/src/address_validator.cc - Issue 237693002: requestAutocomplete should not unlatinize administrative region names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/src/address_validator.cc

Issue 237693002: requestAutocomplete should not unlatinize administrative region names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Canonicalize latinized name without unlatinizing it. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/libaddressinput/chromium/chrome_rule_test.cc ('k') | third_party/libaddressinput/chromium/cpp/src/rule.h » ('j') | third_party/libaddressinput/chromium/cpp/src/rule.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/cpp/src/address_validator.cc

diff --git a/third_party/libaddressinput/chromium/cpp/src/address_validator.cc b/third_party/libaddressinput/chromium/cpp/src/address_validator.cc

index 435f75d935ba15ca452afde02fbc55b25f3de717..56500f9168cd2f0c52c91373648e614451f15b98 100644

--- a/third_party/libaddressinput/chromium/cpp/src/address_validator.cc

+++ b/third_party/libaddressinput/chromium/cpp/src/address_validator.cc

@@ -220,7 +220,7 @@ class AddressValidatorImpl : public AddressValidator {

const std::string& user_input = address.GetFieldValue(sub_field_type);

if (!user_input.empty() &&

FilterAllows(filter, sub_field_type, AddressProblem::UNKNOWN_VALUE) &&

- !rule.CanonicalizeSubKey(user_input, &sub_key)) {

+ !rule.CanonicalizeSubKey(user_input, true, &sub_key)) {

problems->push_back(AddressProblem(

sub_field_type,

AddressProblem::UNKNOWN_VALUE,

@@ -443,6 +443,7 @@ class AddressValidatorImpl : public AddressValidator {

ruleset_it->second->GetLanguageCodeRule(address_data->language_code);

return rule.CanonicalizeSubKey(address_data->administrative_area,

+ false,

&address_data->administrative_area);

}