requestAutocomplete should not unlatinize administrative region names.

third_party/libaddressinput/chromium/cpp/src/rule.cc

 // Copyright (C) 2013 Google Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 // http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 358 matching lines @@
     case DEPENDENT_LOCALITY:
       return IDS_LIBADDRESSINPUT_I18N_INVALID_DEPENDENT_LOCALITY_LABEL;
     case POSTAL_CODE:
       return invalid_postal_code_message_id_;
     default:
       return IDS_LIBADDRESSINPUT_I18N_INVALID_ENTRY;
   }
 }
 
 bool Rule::CanonicalizeSubKey(const std::string& user_input,
+                              bool canonicalize_latin_name,

[Evan Stade, 2014/04/16 21:55:46]

|canonicalize_latin_name| is not quite optimal imo, because in either case
you're doing some degree of canonicalization/normalization. It should be
|keep_input_latin| or |keep_input_script| or something like that.

[please use gerrit instead, 2014/04/16 22:53:27]

Done.

                               std::string* sub_key) const {
+  assert(sub_key != NULL);
+
   if (sub_keys_.empty()) {
     *sub_key = user_input;
     return true;
   }
 
   return GetMatchingSubKey(user_input, sub_keys_, sub_key) ||
       GetMatchingSubKey(user_input, sub_names_, sub_key) ||
-      GetMatchingSubKey(user_input, sub_lnames_, sub_key);
+      (canonicalize_latin_name &&
+       GetMatchingSubKey(user_input, sub_lnames_, sub_key)) ||
+      GetMatchingValue(user_input, sub_lnames_, sub_key);
 }
 
 bool Rule::GetMatchingSubKey(const std::string& target,

[Evan Stade, 2014/04/16 21:55:46]

seems like GetMatchingSubKey and GetMatchingValue should be able to share an
implementation. The sig would look something like:

GetMatchingValue(string target,
                 vector values_to_compare,
                 vector values_to_pick_from,
                 string* output) {
  ...
}

[please use gerrit instead, 2014/04/16 22:53:27]

Done.

                              const std::vector<std::string>& values,
                              std::string* sub_key) const {
+  assert(sub_key != NULL);
   for (size_t i = 0; i < values.size(); ++i) {
     if (LooseStringCompare(values[i], target)) {
       *sub_key = sub_keys_[i];
       return true;
     }
   }
   return false;
 }
 
+bool Rule::GetMatchingValue(const std::string& target,
+                            const std::vector<std::string>& values,
+                            std::string* value) const {
+  assert(value != NULL);
+  for (size_t i = 0; i < values.size(); ++i) {
+    if (LooseStringCompare(values[i], target)) {
+      *value = values[i];
+      return true;
+    }
+  }
+  return false;
+}
+
 }  // namespace addressinput
 }  // namespace i18n