Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 23769007: Fix concurrent osr. (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Fix concurrent osr. InstallOptimizedCode aquires ownership on the compilation info and deletes it on return, tearing down the attached zone. The OptimizingCompiler object is a zone object allocated in just that zone, so it also gets deleted. Effectively, InstallOptimizedCode cleans up when it's done, so the OptimizingCompiler object it receives is invalidated afterwards. R=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16609

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 6 chunks +9 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 3 months ago (2013-09-10 09:20:29 UTC) #1
Yang
On 2013/09/10 09:20:29, Yang wrote: We could also solve this by not having InstallOptimizedCode delete ...
7 years, 3 months ago (2013-09-10 09:21:30 UTC) #2
titzer
lgtm https://codereview.chromium.org/23769007/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/23769007/diff/1/src/compiler.cc#newcode1227 src/compiler.cc:1227: BailoutId ast_id = compiler->info()->osr_ast_id(); I'm not sure why ...
7 years, 3 months ago (2013-09-10 11:02:42 UTC) #3
Yang
7 years, 3 months ago (2013-09-10 11:09:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698