Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2376843002: Pass new pool pointer to the JumpToException stub instead of reloading in through the frame's Code … (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass new pool pointer to the JumpToException stub instead of reloading in through the frame's Code object. This is prep work for lazy deopt without code patching. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/3413e052b30ee12ad41cb73a7f1abb50bba2a3ae

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -46 lines) Patch
M runtime/vm/exceptions.cc View 1 17 chunks +37 lines, -7 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M runtime/vm/simulator_dbc.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/stack_frame.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + tests/language/vm/lazy_deopt_with_exception_and_stacktrace_test.dart View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rmacnak
4 years, 2 months ago (2016-09-27 21:25:25 UTC) #2
Florian Schneider
https://codereview.chromium.org/2376843002/diff/1/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/2376843002/diff/1/runtime/vm/exceptions.cc#newcode156 runtime/vm/exceptions.cc:156: uword saved_pp = 0; ObjectPool& saved_pp = ObjectPool::Handle(); https://codereview.chromium.org/2376843002/diff/1/runtime/vm/exceptions.cc#newcode218 ...
4 years, 2 months ago (2016-09-27 22:21:08 UTC) #3
rmacnak
As discussed offline, passing the pp slot through instead of pp value.
4 years, 2 months ago (2016-09-28 00:29:36 UTC) #4
Florian Schneider
Lgtm https://codereview.chromium.org/2376843002/diff/20001/runtime/vm/stack_frame.h File runtime/vm/stack_frame.h (right): https://codereview.chromium.org/2376843002/diff/20001/runtime/vm/stack_frame.h#newcode68 runtime/vm/stack_frame.h:68: uword saved_caller_pp() const { Since you store the ...
4 years, 2 months ago (2016-09-28 01:30:36 UTC) #5
rmacnak
Committed patchset #2 (id:20001) manually as 3413e052b30ee12ad41cb73a7f1abb50bba2a3ae (presubmit successful).
4 years, 2 months ago (2016-09-28 17:15:16 UTC) #7
rmacnak
4 years, 2 months ago (2016-09-28 17:15:56 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2376843002/diff/20001/runtime/vm/stack_frame.h
File runtime/vm/stack_frame.h (right):

https://codereview.chromium.org/2376843002/diff/20001/runtime/vm/stack_frame....
runtime/vm/stack_frame.h:68: uword saved_caller_pp() const {
On 2016/09/28 01:30:36, Florian Schneider wrote:
> Since you store the slot, this getter would not needed anymore.

Done.

Powered by Google App Engine
This is Rietveld 408576698