Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2376833002: Initial version of Bazel SummaryProvider. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initial version of Bazel SummaryProvider. Only request for a single consistent unlinked package is implemented. Searching for consistent set of linked packages is to be implemented yet. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/536f53f0efb6597b22ce4cef27bb21391870043b

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -0 lines) Patch
A pkg/analyzer/lib/src/summary/bazel_summary.dart View 1 chunk +191 lines, -0 lines 4 comments Download
A pkg/analyzer/test/src/summary/bazel_summary_test.dart View 1 chunk +219 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 2 months ago (2016-09-27 20:32:27 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2376833002/diff/1/pkg/analyzer/lib/src/summary/bazel_summary.dart File pkg/analyzer/lib/src/summary/bazel_summary.dart (right): https://codereview.chromium.org/2376833002/diff/1/pkg/analyzer/lib/src/summary/bazel_summary.dart#newcode42 pkg/analyzer/lib/src/summary/bazel_summary.dart:42: * should call [getPackages] to checked whether there ...
4 years, 2 months ago (2016-09-27 21:04:48 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 536f53f0efb6597b22ce4cef27bb21391870043b (presubmit successful).
4 years, 2 months ago (2016-09-28 00:33:32 UTC) #4
Paul Berry
4 years, 2 months ago (2016-09-28 12:38:20 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2376833002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/bazel_summary.dart (right):

https://codereview.chromium.org/2376833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/bazel_summary.dart:139: } catch (_) {
Could we log the exception somewhere?  It might be useful to help with debugging
if Bazel summary support mysteriously doesn't work on someone's machine.

https://codereview.chromium.org/2376833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/bazel_summary.dart:187: } catch (_) {
Similar comment here.

Powered by Google App Engine
This is Rietveld 408576698