Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

Issue 237683004: Disable applyAuthorStyles (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
index fff6ddee0c6204610b6715a191dde344925ce6bc..24e53ba8fb6ef50832b573b39e384b52c1f1d8fe 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
@@ -4,7 +4,7 @@
library observatory_element;
-import 'dart:math';
+import 'package:observatory/app.dart';
import 'package:polymer/polymer.dart';
/// Base class for all Observatory custom elements.
@@ -24,97 +24,14 @@ class ObservatoryElement extends PolymerElement {
super.attributeChanged(name, oldValue, newValue);
}
- bool get applyAuthorStyles => true;
-
- static String _zeroPad(int value, int pad) {
- String prefix = "";
- while (pad > 1) {
- int pow10 = pow(10, pad - 1);
- if (value < pow10) {
- prefix = prefix + "0";
- }
- pad--;
- }
- return "${prefix}${value}";
- }
-
- String formatTimePrecise(double time) {
- if (time == null) {
- return "-";
- }
- const millisPerHour = 60 * 60 * 1000;
- const millisPerMinute = 60 * 1000;
- const millisPerSecond = 1000;
-
- var millis = (time * millisPerSecond).round();
-
- var hours = millis ~/ millisPerHour;
- millis = millis % millisPerHour;
-
- var minutes = millis ~/ millisPerMinute;
- millis = millis % millisPerMinute;
-
- var seconds = millis ~/ millisPerSecond;
- millis = millis % millisPerSecond;
-
- return ("${_zeroPad(hours,2)}"
- ":${_zeroPad(minutes,2)}"
- ":${_zeroPad(seconds,2)}"
- ".${_zeroPad(millis,3)}");
-
- }
+ String formatTimePrecise(double time) => Utils.formatTimePrecise(time);
- String formatTime(double time) {
- if (time == null) {
- return "-";
- }
- const millisPerHour = 60 * 60 * 1000;
- const millisPerMinute = 60 * 1000;
- const millisPerSecond = 1000;
+ String formatTime(double time) => Utils.formatTime(time);
- var millis = (time * millisPerSecond).round();
+ String formatSeconds(double x) => Utils.formatSeconds(x);
- var hours = millis ~/ millisPerHour;
- millis = millis % millisPerHour;
- var minutes = millis ~/ millisPerMinute;
- millis = millis % millisPerMinute;
-
- var seconds = millis ~/ millisPerSecond;
-
- StringBuffer out = new StringBuffer();
- if (hours != 0) {
- return '${hours}h ${minutes}m ${seconds}s';
- }
- if (minutes != 0) {
- return '${minutes}m ${seconds}s';
- }
- return '${seconds}s';
- }
-
- String formatSeconds(double x) {
- return x.toStringAsFixed(2);
- }
-
-
- String formatSize(int bytes) {
- const int bytesPerKB = 1024;
- const int bytesPerMB = 1024 * bytesPerKB;
- const int bytesPerGB = 1024 * bytesPerMB;
- const int bytesPerTB = 1024 * bytesPerGB;
-
- if (bytes < bytesPerKB) {
- return "${bytes}B";
- } else if (bytes < bytesPerMB) {
- return "${(bytes / bytesPerKB).round()}KB";
- } else if (bytes < bytesPerGB) {
- return "${(bytes / bytesPerMB).round()}MB";
- } else if (bytes < bytesPerTB) {
- return "${(bytes / bytesPerGB).round()}GB";
- } else {
- return "${(bytes / bytesPerTB).round()}TB";
- }
- }
+ String formatSize(int bytes) => Utils.formatSize(bytes);
String fileAndLine(Map frame) {
var file = frame['script']['user_name'];
@@ -125,7 +42,7 @@ class ObservatoryElement extends PolymerElement {
bool isNull(String type) {
return type == 'Null';
}
-
+
bool isError(String type) {
return type == 'Error';
}

Powered by Google App Engine
This is Rietveld 408576698