Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2376753002: Appease TSAN regarding data race in profiler debug counters. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Appease TSAN regarding data race in profiler debug counters. BUG=b/31767249 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d9311af50b7bb051cbe8a0e3f17c049df9648f42

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M runtime/vm/profiler.cc View 1 6 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
4 years, 2 months ago (2016-09-27 18:19:47 UTC) #2
Cutch
LGTM w/c https://chromiumcodereview.appspot.com/2376753002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://chromiumcodereview.appspot.com/2376753002/diff/1/runtime/vm/profiler.cc#newcode72 runtime/vm/profiler.cc:72: memset(&counters_, 0, sizeof(counters_)); Zero counters should be ...
4 years, 2 months ago (2016-09-27 18:20:48 UTC) #3
Cutch
LGTM w/c
4 years, 2 months ago (2016-09-27 18:20:49 UTC) #4
rmacnak
https://chromiumcodereview.appspot.com/2376753002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://chromiumcodereview.appspot.com/2376753002/diff/1/runtime/vm/profiler.cc#newcode72 runtime/vm/profiler.cc:72: memset(&counters_, 0, sizeof(counters_)); On 2016/09/27 18:20:48, Cutch wrote: > ...
4 years, 2 months ago (2016-09-27 19:22:27 UTC) #5
rmacnak
4 years, 2 months ago (2016-09-27 19:27:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d9311af50b7bb051cbe8a0e3f17c049df9648f42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698