Issue 237673017: Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237673017: Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling (Closed)

Created:
6 years, 8 months ago by robertphillips

Modified:
6 years, 8 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix up SK_SUPPORT_DEPRECATED_RECORD_FLAGS so it can be used independent of SK_SUPPORT_LEGACY_PICTURE_CAN_RECORD In the prior configuration one can not have SK_SUPPORT_LEGACY_PICTURE_CAN_RECORD defined and SK_SUPPORT_DEPRECATED_RECORD_FLAGS undefined (as one might when trolling through Chrome/Blink for remaining uses of kOptimizeForClippedPlayback_RecordingFlag)

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	include/core/SkPicture.h	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm I'm ok for internal-plumbing purposes that you just ram these changes in, since there ...

6 years, 8 months ago (2014-04-16 16:58:41 UTC) #2

robertphillips

6 years, 8 months ago (2014-04-16 17:15:21 UTC) #4

Message was sent while issue was closed.

This was reverted in r14226 due to compiler complaints (with both #defines
enabled SkPictureRecorder is double friended).

Expand Messages | Collapse Messages