src/ia32/full-codegen-ia32.cc - Issue 237673007: JumpPatchSites can/should easily deal with uint8 sized offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 237673007: JumpPatchSites can/should easily deal with uint8 sized offsets. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 5622c30d55ed10c0e308d2aed22809a6b07ad13a..3eacdd5bdb5eab6acda5b028b81b8ef84888386d 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -74,7 +74,7 @@ class JumpPatchSite BASE_EMBEDDED {

void EmitPatchInfo() {

if (patch_site_.is_bound()) {

int delta_to_patch_site = masm_->SizeOfCodeGeneratedSince(&patch_site_);

- ASSERT(is_int8(delta_to_patch_site));

+ ASSERT(is_uint8(delta_to_patch_site));

__ test(eax, Immediate(delta_to_patch_site));

#ifdef DEBUG

info_emitted_ = true;

« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »