Issue 237673007: JumpPatchSites can/should easily deal with uint8 sized offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237673007: JumpPatchSites can/should easily deal with uint8 sized offsets. (Closed)

Created:
6 years, 8 months ago by mvstanton

Modified:
6 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

JumpPatchSites can/should easily deal with uint8 sized offsets. Motivation is that x64 nosnapshot builds need a 129 byte delta at the moment. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20776

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/ic-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

mvstanton

Hi Michael, here is the issue we discussed, found in x64 nosnapshot builds. Thx, --Michael

6 years, 8 months ago (2014-04-15 14:41:58 UTC) #1

mvstanton

Committed patchset #1 manually as r20776 (presubmit successful).

6 years, 8 months ago (2014-04-15 15:29:31 UTC) #3

Message was sent while issue was closed.

Hi Michael,

Thanks for the fix!

-Haitao