Issue 237673006: [New Multicolumn] Stay out of the old multicol machinery for column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237673006: [New Multicolumn] Stay out of the old multicol machinery for column-span:all. (Closed)

Created:
6 years, 8 months ago by mstensho (USE GERRIT)

Modified:
6 years, 8 months ago

Reviewers:
ojan

CC:
blink-reviews, mstensho+blink_opera.com, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[New Multicolumn] Stay out of the old multicol machinery for column-span:all. Note that column-span:all isn't supported in the new implementation yet, but while we wait for that to happen, the least thing we can do is to stay alive. We're not going to use this code in the new implementation anyway, when we get there. BUG=344360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171688

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -2 lines)			Patch
A	LayoutTests/fast/multicol/newmulticol/spanner-inside-child-crash.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/multicol/newmulticol/spanner-inside-child-crash-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/237673006/1

6 years, 8 months ago (2014-04-15 18:52:14 UTC) #3

Message was sent while issue was closed.

Change committed as 171688

Expand Messages | Collapse Messages