Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 237673002: remove redundant ifdefs (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, dmikurube+memory_chromium.org
Visibility:
Public.

Description

remove redundant ifdefs OS_CHROMEOS implies OS_LINUX, so OS_LINUX || OS_CHROMEOS can be simplified to OS_LINUX BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M base/security_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/feedback/feedback_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/system-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
thakis: base/security_unittest.cc chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc chrome/browser/feedback/feedback_uploader_unittest.cc jln: base/security_unittest.cc willchan: base/security_unittest.cc third_party/tcmalloc/chromium/src/system-alloc.cc jianli: content/browser/worker_host/test/worker_browsertest.cc
6 years, 8 months ago (2014-04-14 20:34:50 UTC) #1
jln (very slow on Chromium)
On 2014/04/14 20:34:50, Evan Stade wrote: base/security_unittest.cc and third_party/tcmalloc/chromium/src/system-alloc.cc lgtm
6 years, 8 months ago (2014-04-14 21:06:33 UTC) #2
Nico
lgtm
6 years, 8 months ago (2014-04-14 21:11:40 UTC) #3
willchan no longer on Chromium
lgtm
6 years, 8 months ago (2014-04-14 23:27:58 UTC) #4
jianli
lgtm
6 years, 8 months ago (2014-04-15 17:10:23 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-15 17:24:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/237673002/1
6 years, 8 months ago (2014-04-15 17:25:00 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 20:58:13 UTC) #8
Message was sent while issue was closed. 
Change committed as 263993

Powered by Google App Engine
This is Rietveld 408576698