Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2376713002:
[task scheduler] Add uploads to tasks.json (Closed)
Description[task scheduler] Add uploads to tasks.json
BUG=skia:5719
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002
Committed: https://skia.googlesource.com/skia/+/fbf23b80d0a3b742246f991619adb1da4f0aa899
Patch Set 1 #
Total comments: 6
Patch Set 2 : Trim builder name #Patch Set 3 : Backtrack: just copy/paste the builder name #Messages
Total messages: 16 (6 generated)
Description was changed from ========== [task scheduler] Add uploads to tasks.json BUG=skia:5719 ========== to ========== [task scheduler] Add uploads to tasks.json BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002 ==========
borenet@google.com changed reviewers: + benjaminwagner@google.com, borenet@google.com
lgtm https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json File infra/bots/tasks.json (right): https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json#newco... infra/bots/tasks.json:52: "dimensions": ["pool:Skia", "os:Ubuntu", "cpu:x86-64-avx2", "gpu:none"], Why do we need avx2? Same question for Perf. https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json#newco... infra/bots/tasks.json:55: "buildername=<(TASK_NAME)", Is this expecting Upload-... as the buildername? Same question for Perf.
https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json File infra/bots/tasks.json (right): https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json#newco... infra/bots/tasks.json:52: "dimensions": ["pool:Skia", "os:Ubuntu", "cpu:x86-64-avx2", "gpu:none"], On 2016/09/27 14:25:28, dogben wrote: > Why do we need avx2? > > Same question for Perf. Just to be extra sure we're targeting a GCE instance. https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json#newco... infra/bots/tasks.json:55: "buildername=<(TASK_NAME)", On 2016/09/27 14:25:28, dogben wrote: > Is this expecting Upload-... as the buildername? > > Same question for Perf. No, it's the builder name whose results we're uploading.
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json File infra/bots/tasks.json (right): https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json#newco... infra/bots/tasks.json:55: "buildername=<(TASK_NAME)", On 2016/09/27 at 14:27:49, borenet wrote: > On 2016/09/27 14:25:28, dogben wrote: > > Is this expecting Upload-... as the buildername? > > > > Same question for Perf. > > No, it's the builder name whose results we're uploading. So, won't <(TASK_NAME) expand to Upload-Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN in this case?
The CQ bit was unchecked by borenet@google.com
https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json File infra/bots/tasks.json (right): https://codereview.chromium.org/2376713002/diff/1/infra/bots/tasks.json#newco... infra/bots/tasks.json:55: "buildername=<(TASK_NAME)", On 2016/09/27 14:30:46, dogben wrote: > On 2016/09/27 at 14:27:49, borenet wrote: > > On 2016/09/27 14:25:28, dogben wrote: > > > Is this expecting Upload-... as the buildername? > > > > > > Same question for Perf. > > > > No, it's the builder name whose results we're uploading. > > So, won't <(TASK_NAME) expand to > Upload-Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN in this case? D'oh. Yeah. Made the recipe trim the "Upload-" prefix if it exists.
PTAL
lgtm
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [task scheduler] Add uploads to tasks.json BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002 ========== to ========== [task scheduler] Add uploads to tasks.json BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002 Committed: https://skia.googlesource.com/skia/+/fbf23b80d0a3b742246f991619adb1da4f0aa899 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/fbf23b80d0a3b742246f991619adb1da4f0aa899 |
