Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2376703002: Speculative fix for SelectorFilter crash. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh, eae
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for SelectorFilter crash. It looks from the crash log that the string impl() is nullptr. Found no possible way for a null string to be added to the SpaceSplitString, but let's add a null check to see if it helps. R=eae@chromium.org,timloh@chromium.org BUG=646026 Committed: https://crrev.com/c0b82197f7a02cca29479d667557ff4591ba9ed6 Cr-Commit-Position: refs/heads/master@{#421492}

Patch Set 1 #

Patch Set 2 : Added DCHECK + comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/SelectorFilter.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
rune
ptal
4 years, 2 months ago (2016-09-27 13:39:56 UTC) #2
eae
OK, we might want to add a DCHECK? LGTM
4 years, 2 months ago (2016-09-27 17:05:16 UTC) #6
rune
On 2016/09/27 at 17:05:16, eae wrote: > OK, we might want to add a DCHECK? ...
4 years, 2 months ago (2016-09-28 09:13:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376703002/20001
4 years, 2 months ago (2016-09-28 09:13:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 10:39:53 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 10:41:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0b82197f7a02cca29479d667557ff4591ba9ed6
Cr-Commit-Position: refs/heads/master@{#421492}

Powered by Google App Engine
This is Rietveld 408576698