cc/scheduler/scheduler_unittest.cc - Issue 23767011: cc: Always use SetNeedsBeginFrame to request the next BeginFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_unittest.cc

Issue 23767011: cc: Always use SetNeedsBeginFrame to request the next BeginFrame (Closed) Base URL: http://git.chromium.org/chromium/src.git@pollForDrawTriggers

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_unittest.cc

diff --git a/cc/scheduler/scheduler_unittest.cc b/cc/scheduler/scheduler_unittest.cc

index 7074bbef4f7a41dbd027ac3cde8f23c6ba741d66..9269fc5712f97704a912611381fcd92859a26f66 100644

--- a/cc/scheduler/scheduler_unittest.cc

+++ b/cc/scheduler/scheduler_unittest.cc

@@ -234,8 +234,9 @@ TEST(SchedulerTest, RequestCommitAfterBeginFrameSentToMainThread) {

// Tick should draw but then begin another frame for the second commit.

scheduler->BeginFrame(BeginFrameArgs::CreateForTesting());

EXPECT_TRUE(client.needs_begin_frame());

- EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client, 0, 2);

- EXPECT_ACTION("ScheduledActionSendBeginFrameToMainThread", client, 1, 2);

+ EXPECT_ACTION("ScheduledActionDrawAndSwapIfPossible", client, 0, 3);

+ EXPECT_ACTION("ScheduledActionSendBeginFrameToMainThread", client, 1, 3);

+ EXPECT_ACTION("SetNeedsBeginFrameOnImplThread", client, 2, 3);

danakj 2013/09/12 20:57:29 Can you update the comment here to explain the new

client.Reset();

// Finish the second commit to go back to quiescent state and verify we no

« cc/scheduler/scheduler.cc ('K') | « cc/scheduler/scheduler.cc ('k') | no next file » | no next file with comments »