Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 23767009: Move Maybe template into v8.h so it can be used by SetResourceConstraints (Closed)

Created:
7 years, 3 months ago by rmcilroy
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Move Maybe template into v8.h so it can be used by SetResourceConstraints BUG= R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M include/v8.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
As discussed, moving Maybe template into public header. Let me know if you want it ...
7 years, 3 months ago (2013-09-06 14:05:39 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-09 07:17:09 UTC) #2
rmcilroy
On 2013/09/09 07:17:09, Sven Panne wrote: > lgtm Thanks Sven. Could you land this for ...
7 years, 3 months ago (2013-09-09 08:27:42 UTC) #3
Sven Panne
7 years, 3 months ago (2013-09-10 10:53:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698