Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 23767004: Revert "Handling of multiple concurrent requests from different clients in OAuth2TokenService" (Closed)

Created:
7 years, 3 months ago by eustas
Modified:
7 years, 3 months ago
Reviewers:
zel
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Visibility:
Public.

Description

Revert "Handling of multiple concurrent requests from different clients in OAuth2TokenService" This reverts commit 2a0ff28378173300b81b2874736c30a6c48d0029. Reason: BuildBot Vista fails TokenServiceUpdateClearsCache test. BUG= TBR=zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -373 lines) Patch
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 6 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/signin/profile_oauth2_token_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/signin/profile_oauth2_token_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/signin/profile_oauth2_token_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.h View 3 chunks +0 lines, -12 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.cc View 4 chunks +2 lines, -11 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.h View 8 chunks +19 lines, -56 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 23 chunks +48 lines, -134 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 23 chunks +20 lines, -135 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/23767004/1
7 years, 3 months ago (2013-09-05 04:59:53 UTC) #1
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83044
7 years, 3 months ago (2013-09-05 05:38:44 UTC) #2
eustas
7 years, 3 months ago (2013-09-05 05:53:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r221350.

Powered by Google App Engine
This is Rietveld 408576698