When onPageFinished calls onNewPicture, pass null picture on SDK>=JB MR2.

When onPageFinished calls onNewPicture, pass null picture on SDK>=JB MR2.

onPagefinished generates a synthetic onNewPicture callback if a picture
listener is registered. We probably shouldn't change that behaviour,
even though it was introduced to fix a different CTS test flake, because
applications may well be relying upon it. Given that, it should at least
respect the documented behaviour that the picture instance it passes
should be null on JB MR2 and above.

BUG=650641
Committed: https://crrev.com/3d240ed8eb78d66415e16773f0265fb902f0434e
Cr-Commit-Position: refs/heads/master@{#421222}

[Tobias Sargeant, 2016-09-27 13:09:46]

tobiasjs@chromium.org changed reviewers:
+ torne@chromium.org

[Tobias Sargeant, 2016-09-27 13:11:07]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 13:11:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 13:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 13:44:59]

Dry run: This issue passed the CQ dry run.

[Torne, 2016-09-27 15:38:20]

lgtm

[Tobias Sargeant, 2016-09-27 15:41:07]

The CQ bit was checked by tobiasjs@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:41:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:46:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 15:49:10]

Description was changed from

==========
When onPageFinished calls onNewPicture, pass null picture on SDK>=JB MR2.

onPagefinished generates a synthetic onNewPicture callback if a picture
listener is registered. We probably shouldn't change that behaviour,
even though it was introduced to fix a different CTS test flake, because
applications may well be relying upon it. Given that, it should at least
respect the documented behaviour that the picture instance it passes
should be null on JB MR2 and above.

BUG=650641
==========

to

==========
When onPageFinished calls onNewPicture, pass null picture on SDK>=JB MR2.

onPagefinished generates a synthetic onNewPicture callback if a picture
listener is registered. We probably shouldn't change that behaviour,
even though it was introduced to fix a different CTS test flake, because
applications may well be relying upon it. Given that, it should at least
respect the documented behaviour that the picture instance it passes
should be null on JB MR2 and above.

BUG=650641

Committed: https://crrev.com/3d240ed8eb78d66415e16773f0265fb902f0434e
Cr-Commit-Position: refs/heads/master@{#421222}
==========

[commit-bot: I haz the power, 2016-09-27 15:49:11]

Patchset 1 (id:??) landed as
https://crrev.com/3d240ed8eb78d66415e16773f0265fb902f0434e
Cr-Commit-Position: refs/heads/master@{#421222}